Sc/converters coupling #1558
Merged
Sc/converters coupling #1558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1558 +/- ##
===========================================
- Coverage 92.75% 79.54% -13.21%
===========================================
Files 451 452 +1
Lines 35990 36004 +14
===========================================
- Hits 33380 28636 -4744
- Misses 2610 7368 +4758
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Added interface coupling docs to the main menu.
Moved converter coupling section.
Added some documentation on coupling converters.
ranocha
requested changes
Jul 25, 2023
…rixi.jl into sc/converters_coupling
to avoid type instability.
to coupling functions, as suggested by Andrew and Daniel.
sloede
reviewed
Jan 31, 2024
sloede
approved these changes
Jan 31, 2024
|
@ranocha @efaulhaber Would you like to review this again or are you ok with the responses to your previous reviews? |
|
I guess I'm okay. |
|
I don't know whether I chekced everything since that has been quite some time ago. We can merge this if you think it's fine, @sloede - there is no need for me to review it from my point of view if you're satisfied |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interface coupling through converter functions. This feature extends the already existing coupling functionality by allowing the user to write converter functions. Those convert values from one system to the other and vice versa. Those converted values are then used as Dirichlet boundary condition of the system. This makes it possible to couple systems that do not share variables, but offer the option of converting variables, like Vlasov and MHD.
Nota Bene:
Currently the coordinate values on the nodes can differ by machine precision when simulating the mesh and when splitting the mesh in multiple domains. This is an issue coming from the coordinate interpolation on the nodes. As a result, running a simulation in a single system and in two coupled domains may result in a difference of the order of the machine precision. While this is not an issue for most practical problems, it is best to keep this in mind when comparing test runs.